Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced jsr-305 annotations with spotbugs annotations #1055

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Replaced jsr-305 annotations with spotbugs annotations #1055

merged 1 commit into from
Nov 2, 2021

Conversation

StefanSpieker
Copy link
Contributor

Replaced jsr-305 annotations with spotbugs annotations, as done in jenkins some time ago: jenkinsci/jenkins#4604
I also removed some obsolete imports and added some missing @NonNull annotations where I saw them.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe added the enhancement Improvements label Oct 23, 2021
Vlatombe
Vlatombe approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vlatombe Vlatombe merged commit aed016b into jenkinsci:master Nov 2, 2021
@StefanSpieker StefanSpieker deleted the jsr-305 branch November 2, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
enhancement Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanSpieker @Vlatombe