[JENKINS-31660] avoid reading unnecessary test results from disk #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a few days of testing on a server with 10k+ builds it seems the StackOverflowErrors are gone and the server is more responsive. @olivergondza I would like to ask you or one of the other maintainers for a review. |
|
@jenkinsci/code-reviewers sorry for nagging, but could someone please have a look at this? |
abayer
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-31660
In case the a test was skipped, we don't need to know if it had previous failures, which allows us to avoid loading a lot of data from the disk and avoid StackOverflowError (in case the test was always skipped, we avoid loading all the previous builds).
There are two methods that recompute the failedSince field, one of them handled skipped builds correctly, the other one did not. With this PR they will both use the same logic.