enhance support for EnvInject Plugin #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
kamilszymanski
force-pushed
the
envinject-plugin-support
branch
2 times, most recently
from
2c1ee7e to
8e12e87
Compare
kamilszymanski
force-pushed
the
envinject-plugin-support
branch
from
8e12e87 to
cfa105b
Compare
|
I'm OK with adding the closure and the maskPasswordParameters option, but adding the passwords options is problematic. It enables users to use plain text passwords in their DSL scripts, which is a no-go. And apart from that, it's not working as expected because the passwords need to be stored encrypted. <EnvInjectPasswordWrapper plugin="[email protected]">
<injectGlobalPasswords>false</injectGlobalPasswords>
<maskPasswordParameters>true</maskPasswordParameters>
<passwordEntries>
<EnvInjectPasswordEntry>
<name>id1</name>
<value>MhLlk0NdjNgM5uJfrXaXEKzUM+Irm7g8rzGo7L1jO8A=</value>
</EnvInjectPasswordEntry>
<EnvInjectPasswordEntry>
<name>id2</name>
<value>LwJ8humk1V1CSMqdeNRNlo8PSVrf+7T4mWribbowry0=</value>
</EnvInjectPasswordEntry>
</passwordEntries>
</EnvInjectPasswordWrapper> |
kamilszymanski
force-pushed
the
envinject-plugin-support
branch
from
cfa105b to
4f204b0
Compare
|
I've removed support for storing passwords in DSL scripts |
| } | ||
|
|
||
| /** | ||
| * Defines job passwords and inject them as environment variables. Defaults to {@code true}. |
There was a problem hiding this comment.
The GroovyDoc does not fit to the method.
kamilszymanski
force-pushed
the
envinject-plugin-support
branch
from
9921eba to
3a4647a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.