Replace jsr-305 annotations with SpotBugs ones #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
May 14, 2020
There was a problem hiding this comment.
Thanks, it should be enough for the time being.
In the future we should also port the pom.xml patch from jenkinsci/jenkins#4604 , but it can be done https://github.com/jenkinsci/pom so that it applies to all Jenkins library repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
Similarly to jenkinsci/jenkins#4604 , we should remove JSR annotations and use ones supplied by SpotBugs.
It should also help towards building JFR with JDK 11.
This change as it stands introduces several "deprecated usage" compile warnings because of the bom enforced version of
org.jenkins-ci:version-numberlibrary. Once the bom is updated and the library version is changed from1.6to at least1.7, the warnings will disappear.