Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71794] Redesign executors widget | UX #8459

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

niralmaruda
Copy link
Contributor

@niralmaruda niralmaruda commented Sep 3, 2023

Fixes: JENKINS-71794
The current executors widget layout contains a lot of unnecessary free space. Refer JENKINS-71794 for more details.

The changes are implemented in both PR:core as well as PR:workflow-durable-task-step-plugin to maintain consistency in design. But if any downgraded version of core is used then user will still see the inconsistency in design as shown in second image.

Testing done

image

This is how it'll display if used with downgraded core version.

image

Submitter checklist

Preview Give feedback

Fixes: JENKINS-71794: The current build queue layout contains a lot of unnecessary free space.
@NotMyFault NotMyFault changed the title Fixes: JENKINS-71794 Redesign build queue | UX [JENKINS-71794] Redesign build queue | UX Sep 3, 2023
@NotMyFault
Copy link
Member

How well does that look with folders¿

@niralmaruda
Copy link
Contributor Author

How well does that look with folders¿

@NotMyFault folders? not sure about that.

@jglick
Copy link
Member

jglick commented Sep 7, 2023

To avoid confusion, please rename the Jira issue and this PR to clarify that you are patching the executor widget, not the build queue widget.

@NotMyFault
Copy link
Member

How well does that look with folders¿

@NotMyFault folders? not sure about that.

I took a look yesterday creating a longer folder name with several names and it seems to push the progress bar below the text and make the breadcrumbs invisible.

Can you take a look? It feels this makes the current implementation worse than improving it, but these are just my thoughts.

@niralmaruda
Copy link
Contributor Author

How well does that look with folders¿

@NotMyFault folders? not sure about that.

I took a look yesterday creating a longer folder name with several names and it seems to push the progress bar below the text and make the breadcrumbs invisible.

Can you take a look? It feels this makes the current implementation worse than improving it, but these are just my thoughts.

Sure, I'll take a look into it.

@daniel-beck daniel-beck changed the title [JENKINS-71794] Redesign build queue | UX [JENKINS-71794] Redesign executors widget | UX Sep 9, 2023
@abhishekmaity
Copy link
Contributor

/label web-ui

@comment-ops-bot comment-ops-bot bot added the web-ui The PR includes WebUI changes which may need special expertise label Sep 28, 2023
@Wadeck Wadeck added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Oct 3, 2023
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 18, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-approved @jenkinsci/core-security-review reviewed this PR for security issues unresolved-merge-conflict There is a merge conflict with the target branch. web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants