Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java.util.concurrent from --add-opens list #6392

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

basil
Copy link
Member

@basil basil commented Mar 21, 2022

I am not sure why we originally added --add-opens java.base/java.util.concurrent=ALL-UNNAMED to the Java 17 preview, but it seems unnecessary in principle (why would we be persisting a concurrent data structure?), and I seem to be able to run a Pipeline job just fine without it locally. So let us see if we can remove this custom directive without any negative side effects.

This PR is in draft state for now as I am not entirely sure this is doable. If the core tests and the plugin BOM tests pass with it removed, then I will mark this as ready for review.

If this PR is successful, I plan to repeat similar exercises for the other --add-opens directives until we arrive at the minimal set needed for XStream in the context of Jenkins.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added work-in-progress The PR is under active development, not ready to the final review skip-changelog Should not be shown in the changelog labels Mar 21, 2022
@basil
Copy link
Member Author

basil commented Mar 22, 2022

Core tests passed with the removal of java.util.concurrent, and all plugin BOM tests passed except for workflow-cps-plugin. I proposed jenkinsci/workflow-cps-plugin#518 to see if we might be able to change that.

@basil
Copy link
Member Author

basil commented Mar 23, 2022

Successful Java 17 BOM run with the latest incremental from this PR and the latest incremental from jenkinsci/workflow-cps-plugin#518. I believe this PR is ready for review. It will be ready for merge once jenkinsci/workflow-cps-plugin#518 is merged and released.

@basil basil marked this pull request as ready for review March 23, 2022 05:11
@basil
Copy link
Member Author

basil commented Mar 27, 2022

jenkinsci/workflow-cps-plugin#518 was released in 2683.vd0a_8f6a_1c263, so I am moving this PR out of the "work in progress" state.

@basil basil removed the work-in-progress The PR is under active development, not ready to the final review label Mar 27, 2022
@basil basil requested a review from a team March 27, 2022 22:18
@basil
Copy link
Member Author

basil commented Mar 28, 2022

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 28, 2022
@basil basil merged commit 2716b07 into jenkinsci:master Mar 29, 2022
@basil basil deleted the concurrent branch March 29, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants