Remove java.util.concurrent
from --add-opens
list
#6392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why we originally added
--add-opens java.base/java.util.concurrent=ALL-UNNAMED
to the Java 17 preview, but it seems unnecessary in principle (why would we be persisting a concurrent data structure?), and I seem to be able to run a Pipeline job just fine without it locally. So let us see if we can remove this custom directive without any negative side effects.This PR is in draft state for now as I am not entirely sure this is doable. If the core tests and the plugin BOM tests pass with it removed, then I will mark this as ready for review.
If this PR is successful, I plan to repeat similar exercises for the other
--add-opens
directives until we arrive at the minimal set needed for XStream in the context of Jenkins.Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).