Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-61212] Update Tyrus (WebSocket client) to 2.0.1 #5716

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 7, 2021

Untested but this may fix JENKINS-61212 for CLI (not agents!) by picking up eclipse-ee4j/tyrus#707.

Proposed changelog entries

  • WebSocket connections now work when the Jenkins controller is running Java 11 and using self-terminated TLS.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #5705 I suppose.

@jglick
Copy link
Member Author

jglick commented Sep 7, 2021

Hmm, yeah. I am confused since https://github.com/eclipse-ee4j/tyrus/releases/tag/2.0.1 says it was released just an hour ago. They do something weird with tags.

@daniel-beck
Copy link
Member

It's just GH releases having its own uneditable date: https://github.com/eclipse-ee4j/tyrus/tree/2.0.1 is a week old.

@timja timja added dependencies Pull requests that update a dependency file java Pull requests that update Java code ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Sep 13, 2021
@timja
Copy link
Member

timja commented Sep 13, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@oleg-nenashev oleg-nenashev merged commit fa99c19 into jenkinsci:master Sep 15, 2021
@oleg-nenashev oleg-nenashev added the bug For changelog: Minor bug. Will be listed after features label Sep 15, 2021
@jglick jglick deleted the tyrus-JENKINS-61212 branch September 15, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features dependencies Pull requests that update a dependency file java Pull requests that update Java code ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants