-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-63022] Make Fingerprint Storage Engine configurable from the config page #4834
Conversation
IIUC I need to obtain the object (singleton) from the list of configured descriptors. The problem is that hetero-list is not persisting this data. |
So data binding does not seem to be happening because of |
core/src/main/java/jenkins/fingerprints/GlobalFingerprintConfiguration.java
Outdated
Show resolved
Hide resolved
core/src/main/resources/jenkins/fingerprints/GlobalFingerprintConfiguration/config.jelly
Outdated
Show resolved
Hide resolved
What I need to now figure out is how to fix the implementation of |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add any log lines?
Downstream PR: jenkinsci/redis-fingerprint-storage-plugin#36 |
core/src/main/resources/jenkins/fingerprints/GlobalFingerprintConfiguration/config.jelly
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We might need to adjust API in the future, but all important data is behind Beta flags
core/src/main/java/jenkins/fingerprints/FileFingerprintStorage.java
Outdated
Show resolved
Hide resolved
core/src/main/java/jenkins/fingerprints/FingerprintStorage.java
Outdated
Show resolved
Hide resolved
core/src/main/java/jenkins/fingerprints/GlobalFingerprintConfiguration.java
Outdated
Show resolved
Hide resolved
core/src/main/java/jenkins/fingerprints/GlobalFingerprintConfiguration.java
Outdated
Show resolved
Hide resolved
This PR is ready-for-merge now, we'll merge it after 24 hours if there's no negative feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last changes do not change the PR in principle, so I think we do not need to reset the merge timeout. It may be merged in 6 hours
See JENKINS-63022.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).