Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump slf4j from 1.7.25 to 1.7.26 #4118

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Bump slf4j from 1.7.25 to 1.7.26 #4118

merged 1 commit into from
Jul 19, 2019

Conversation

longngn
Copy link
Contributor

@longngn longngn commented Jul 18, 2019 •
edited
Loading

GitHub release (commits and diff): https://github.com/qos-ch/slf4j/releases/tag/v_1.7.26
Changelog: https://www.slf4j.org/news.html

Proposed changelog entries

  • Internal: Update slf4j version from 1.7.25 to 1.7.26

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

@oleg-nenashev
Copy link
Member

Diff: qos-ch/slf4j@v_1.7.25...v_1.7.26

oleg-nenashev
oleg-nenashev approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varyvol
Copy link

varyvol commented Jul 18, 2019

There are removed classes in the changes...would they affect?

fcojfernandez
fcojfernandez approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@fcojfernandez fcojfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing the diff, LGTM

@longngn
Copy link
Contributor Author

longngn commented Jul 18, 2019

Changelog updated

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 18, 2019
@oleg-nenashev
Copy link
Member

Will merge tomorrow if no negative feedback

@oleg-nenashev oleg-nenashev merged commit 38e94d1 into jenkinsci:master Jul 19, 2019
@longngn longngn deleted the patch-1 branch July 19, 2019 14:54
@longngn longngn mentioned this pull request Jul 19, 2019
Closed
@jglick jglick mentioned this pull request Sep 9, 2019
Merged
jglick added a commit to jglick/bom that referenced this pull request Sep 27, 2019
@jglick
Pending jenkinsci/plugin-pom#229 (or rejected jenkinsci/plugin-pom#219)…
2079ea6 
…, need to work around jenkinsci/jenkins#4118 when declaring a new LTS baseline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcojfernandez fcojfernandez fcojfernandez approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@longngn @oleg-nenashev @varyvol @fcojfernandez