Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a variable for bold font weight #10176

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jan 17, 2025

Standardises bold fonts on Jenkins using a CSS variable, overall the UI should look the same - some elements are a little lighter/less heavy on the eye. Overall not very noticeable but a quality of life update - using a variable keeps it consistent and easy to change in the future.

Testing done

  • Works as expected, font weights are slightly less bold across Jenkins

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 17, 2025
@janfaracik janfaracik requested a review from a team January 17, 2025 22:13
@@ -16,6 +16,7 @@
margin: 0;
padding: 0.5rem 0.9rem;
font-size: 0.875rem;
font-weight: normal;
Copy link
Contributor Author

@janfaracik janfaracik Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly links and buttons with the class jenkins-button have different weights, this fixes that. Noticeable on the REST API/Jenkins version buttons.

@@ -119,18 +119,18 @@
.app-about-heading {
font-weight: 600;
font-family: Georgia, serif;
font-size: 1.6rem;
font-size: 1.5rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related - but 1.6rem is 25.6px which would look odd as its not a whole number.

color: var(--text-color-secondary);
margin: 0;
}

.app-about-paragraph {
font-size: 1.125rem;
font-size: 1rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted for consistency.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja added skip-changelog Should not be shown in the changelog and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 17, 2025
@timja
Copy link
Member

timja commented Jan 17, 2025

@janfaracik rfe is used as 'enhancement' / 'feature' and goes on the changelog, use skip-changelog for things that aren't user visible.

@krisstern
Copy link
Member

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants