-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a variable for bold font weight #10176
base: master
Are you sure you want to change the base?
Conversation
@@ -16,6 +16,7 @@ | |||
margin: 0; | |||
padding: 0.5rem 0.9rem; | |||
font-size: 0.875rem; | |||
font-weight: normal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annoyingly links and buttons with the class jenkins-button
have different weights, this fixes that. Noticeable on the REST API/Jenkins version buttons.
@@ -119,18 +119,18 @@ | |||
.app-about-heading { | |||
font-weight: 600; | |||
font-family: Georgia, serif; | |||
font-size: 1.6rem; | |||
font-size: 1.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really related - but 1.6rem
is 25.6px
which would look odd as its not a whole number.
color: var(--text-color-secondary); | ||
margin: 0; | ||
} | ||
|
||
.app-about-paragraph { | ||
font-size: 1.125rem; | ||
font-size: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@janfaracik |
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. |
Standardises bold fonts on Jenkins using a CSS variable, overall the UI should look the same - some elements are a little lighter/less heavy on the eye. Overall not very noticeable but a quality of life update - using a variable keeps it consistent and easy to change in the future.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist