Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify styling for 'Search bar' #10174

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jan 17, 2025

This PR updates and simplifies the styling for the search bar component, where rather than reinvent the wheel in terms of design we just inherit the design from the existing input and dropdown classes.

This results in a mild UI change for the search bar, but keeps it consistent with other inputs:

Before
image

After
image

I've also simplified results for the search bar, we now reuse the styling of the dropdown component rather than have our own unique style for search.

Testing done

  • Tested command palette, regular search and plugin search
  • Results appear as expected

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik requested a review from a team January 17, 2025 18:33
@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 17, 2025
@janfaracik janfaracik added skip-changelog Should not be shown in the changelog and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant