Require Jenkins 2.361.4 or newer and Java 11 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Subzer0570
commented
Jan 2, 2023
•
Subzer0570
commented
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
MarkEWaite
requested changes
Jan 2, 2023
pom.xml
Outdated
Comment on lines
57
to
58
| <!-- <jenkins.version>2.346.3</jenkins.version>--> | ||
| <jenkins.version>2.361.1</jenkins.version> |
There was a problem hiding this comment.
This change also needs the changes described in "Update Jenkins version". The bom entry will need to change form bom-2.346.x to bom-2.361.x. Based on "Update Jenkins version" it should require 2.361.4 rather than 2.361.1.
Suggested change
| <!-- <jenkins.version>2.346.3</jenkins.version>--> | |
| <jenkins.version>2.361.1</jenkins.version> | |
| <jenkins.version>2.361.4</jenkins.version> |
MarkEWaite
changed the title
|
@Subzer0570 this supersedes #21 and provides a better description for users. Thanks for doing it! |
MarkEWaite
approved these changes
Jan 3, 2023
|
The Jenkinsfile will need to be updated to remove the testing of Java 8, since this change will drop support for Java 8 and will require Java 11 or Java 17. I am an administrator of ci.jenkins.io so I was able to modify the job definition with a replay. The check job should pass on the current run because I removed the Java 8 test from the job definition in the replay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.