Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.346.3 or newer #16

Merged
merged 8 commits into from
Nov 28, 2022
Merged

Conversation

MarkEWaite
Copy link
Contributor

Modernize plugin build environment

  • Escape jelly content by default
  • Defend against null pointer exceptions
  • Use try with resources to close files consistently
  • Prevent null pointer exception
  • Skip redundant null check
  • Use most recent parent pom and build tooling
  • Add Jenkinsfile for CI

Update the plugin to require Jenkins 2.346.3 or newer and to support running with Java 8, Java 11, and Java 17.

Resolves several spotbugs issues by using null checks and by using try with resources to assure that files are closed appropriately.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite merged commit 812399f into jenkinsci:master Nov 28, 2022
@MarkEWaite MarkEWaite deleted the modernize branch November 28, 2022 13:14
@MarkEWaite MarkEWaite added chore Maintenance enhancement New features and improvements and removed chore Maintenance labels Nov 28, 2022
@MarkEWaite MarkEWaite changed the title Modernize plugin build environment Require Jenkins 2.346.3 or newer Nov 28, 2022
@MarkEWaite MarkEWaite added chore Maintenance and removed enhancement New features and improvements labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant