Migrate tests to JUnit5 #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
olamy
reviewed
Mar 4, 2025
| private JenkinsRule j; | ||
|
|
||
| @BeforeEach | ||
| void setUp(JenkinsRule rule) { |
There was a problem hiding this comment.
I didn't look at how the junit5 extension is done, but it looks like something which should be done automatically or just by adding some annotations to the JenkinsRule j field
There was a problem hiding this comment.
While I do agree that it would be more convenient, it is not (yet) working that way: See https://javadoc.jenkins.io/component/jenkins-test-harness/org/jvnet/hudson/test/junit/jupiter/WithJenkins.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.