Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing javadoc #241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rahulsom
Copy link

This shows up as a warning during the build.
Though the method is deprecated, it's worth documenting it.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@rahulsom rahulsom marked this pull request as ready for review February 16, 2025 19:07
@sghill
Copy link

sghill commented Feb 16, 2025

We shade this class with a task so it's available to buildscripts without having to add another repository or a settings plugin.

Upstream would be the place to add the javadoc, otherwise it's going to get lost on the next pull.

rahulsom pushed a commit to rahulsom/lib-version-number that referenced this pull request Feb 16, 2025
This shows up as a warning during the build.
Though the method is deprecated, it's worth documenting it.

See: jenkinsci/gradle-jpi-plugin#241 (comment)
This shows up as a warning during the build.
Though the method is deprecated, it's worth documenting it.
MarkEWaite pushed a commit to jenkinsci/lib-version-number that referenced this pull request Feb 16, 2025
This shows up as a warning during the build.
Though the method is deprecated, it's worth documenting it.

See: jenkinsci/gradle-jpi-plugin#241 (comment)

Co-authored-by: Rahul Somasunderam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants