chore: Support builds on JDK 17+ #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with JDK 17 and 21. The version of CodeNarc present did not work with JDK 17+. That also prevented this plugin from being used in composite builds that required JDK 17+. This change allows using JDK 17 for the build. Some new rules were being violated, and have been added to exclusions.
rahulsom
force-pushed
the
support-jdk-17
branch
from
0a5612a to
eaa3cb5
Compare
sghill
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with JDK 17 and 21.
The version of CodeNarc present did not work with JDK 17+. That also prevented this plugin from being used in composite builds that required JDK 17+.
This change allows using JDK 17 for the build.
Some new rules were being violated, and have been added to exclusions.
Testing done
Submitter checklist