Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch filter support #49

Merged
merged 9 commits into from
Nov 24, 2018
Merged

branch filter support #49

merged 9 commits into from
Nov 24, 2018

Conversation

chenz85
Copy link
Contributor

@chenz85 chenz85 commented Nov 2, 2018

description

add a branch filter to jenkins job, only push event with matched ref name should trigger job.

Types of changes

  • [ x] New feature (non-breaking change which adds functionality)

Further comments

  • add "branch filter" field in job config, default value set to "master"
  • if set "branch filter" to empty or "*", means to handle any ref in this job
  • otherwise, only trigger job while ref name ends with value of "branch filter"

@sanderv32
Copy link
Contributor

sanderv32 commented Nov 3, 2018

Is this still work in progress or can this be merged? Also can you write a test for this new feature?

@chenz85
Copy link
Contributor Author

chenz85 commented Nov 3, 2018

i have test in local server and works fine. i will write a test for it later today.

@chenz85
Copy link
Contributor Author

chenz85 commented Nov 4, 2018

Is this still work in progress or can this be merged? Also can you write a test for this new feature?

i have added test case to branch filter. and i changed default filter to empty so it will compatible prev version.

@sanderv32
Copy link
Contributor

The checks are green, so if you're ready i can merge

@chenz85
Copy link
Contributor Author

chenz85 commented Nov 12, 2018

The checks are green, so if you're ready i can merge

that will be great. i think this feature is very useful.

@sanderv32 sanderv32 merged commit 2c7fca6 into jenkinsci:master Nov 24, 2018
@urusha
Copy link

urusha commented May 16, 2019

@sanderv32 Could it be released, please, or where could I find master build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants