Added new hook events sent by Gitlab starting in 9.5.4 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the 9.5.4 upgrade of Gitlab, when testing the hooks from the "integrations" section, the "X-Gitlab-Event" with the event description is sent in the form "xxx Event" (i.e. "Push Event") instead of the regular "xxx Hook", showing a 404 error on the Gitlab side when the hook is actually working as Gitlab does send "xxx Hook" kind of headers when the actual event is triggered.
Although it looks like a bug/inconsistency from Gitlab, this change extends the list of supported headers to overcome this inconsistency.