Unable to auto merge on successful build using Jenkins CI

[jejohns]

I have repos configured via the Jenkins CI service to trigger builds when a merge request is created. If I select the "Merge when build succeeds" option after creating the merge request, the merge request remains in a state where it's indefinitely waiting on a successful build result. While it's stuck in this state, Jenkins has already returned a successful result but the state of the merge request remains unchanged.

I can't tell if it's a issue on the Gitlab side or the Jenkins Gitlab plugin side. I am using Gitlab 8.3.4 with Jenkins Gitlab plugin 1.1.28. I followed the instructions here for setup: http://doc.gitlab.com/ee/integration/jenkins.html

[vstriz]

I'm observing exactly same thing.

[kflorence]

+1

[telisior]

Same problem for me.
I still observe it on GitLab 8.4.2.

[sebastienbonami]

👍
I think the issue is on GitLab side, so I created this ticket: https://gitlab.com/gitlab-org/gitlab-ce/issues/13269

[ayufan]

I did check that. The Jenkins plugin should send the ref (just name without the refs/heads or refs/tags) in order for Commit Status and automatic merge to work.

[WonderCsabo]

I am also seeing this bug on Gitlab 8.3 and 8.5.

[ayufan]

WonderCsabo: Thanks. I'll verify it once again :)

[coder-hugo]

According to http://doc.gitlab.com/ce/api/commits.html#post-the-build-status-to-a-commit the ref has to be a tag or branch not the commit hash.

[coder-hugo]

Was closed by accident.

[ayufan]

@coder-hugo Is there anything that I can help with?

[coder-hugo]

@ayufan a bit more of time to work on the plugin would be helpful 😉
I'll hopefully fix this during my code cleanups within the next days.
I just added the last comment and the label to this issue while looking through all open issues to get an overview what needs to be done cause I'm the new lead maintainer since a few days.

[ayufan]

Awesome. @coder-hugo if you need any help from GitLab side I'm more than happy to help you with that :)

[sebastienbonami]

@coder-hugo I tried a quick fix and it's solving the issue. In GitLabMergeRequest.java: change third parameter of createCommitStatus method from objectAttributes.getLastCommit().getId() to objectAttributes.getSourceBranch(). Tags should also be supported I guess.

Reference: #127 (comment)

[vstriz]

Is there any update on this? I have to keep reminding my team to not press that "oh so inviting" button. This would a wonderful feature to have working...