Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source branch with "Accept merge request on success" #181

Closed
sebastienbonami opened this issue Jan 15, 2016 · 3 comments
Closed

Remove source branch with "Accept merge request on success" #181

sebastienbonami opened this issue Jan 15, 2016 · 3 comments
Assignees
@omorillo
Labels
feature request fix-pending

Comments

@sebastienbonami
Copy link
Contributor

Hi, it would be nice to have the option to remove source branch automatically when the functionality "Accept merge request on success" is used in a Jenkins job.

Thanks!
@omorillo omorillo self-assigned this May 24, 2016
@omorillo
Copy link
Contributor

I'm on it.

@omorillo
Copy link
Contributor

omorillo commented May 29, 2016 •
edited
Loading

My implementation for this issue is now ready.

Unfortunately, I observed a bug in the GitLab API implementation which results in the source branch always to be removed when using the "Accept merge request on success" feature, no matter whether the "should_remove_source_branch" flag was enabled or not. I could observe this behaviour in GitLab CE version 8.7.3 and 8.7.6.

Creating an issue on the GitLab bug tracker (https://gitlab.com/gitlab-org/gitlab-ce/issues/17992).

As the feature can not properly work at the moment, the changeset will not be added to the master yet. A pull request will be put in place which will be merged to master, once the issue on GitLab site is fixed.

omorillo added a commit to omorillo/gitlab-plugin that referenced this issue Jun 12, 2016
@omorillo
New feature: Remove source branch with 'Accept merge request on success'
da80b53 
Fixes jenkinsci#181
@omorillo omorillo mentioned this issue Jun 12, 2016
Closed
@sebastienbonami
Copy link
Contributor Author

Well... this feature is now present on GitLab's side so I don't need this anymore.

@omehegan omehegan mentioned this issue Jun 29, 2018
Merged
exceed-alae pushed a commit to exceed-alae/gitlab-plugin that referenced this issue May 20, 2022
@DavidTanner
Merge pull request jenkinsci#181 from DavidTanner/arcivanov-issue_158
0198e3c 
Arcivanov issue 158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omorillo omorillo

Labels
feature request fix-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New feature: Allow for source branch removal upon MR acceptance omorillo/gitlab-plugin
4 participants
@omehegan @omorillo @coder-hugo @sebastienbonami