Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab 8.0 Commit Status Broken #111

Closed
ahaeber opened this issue Sep 24, 2015 · 9 comments · Fixed by #127
Closed

GitLab 8.0 Commit Status Broken #111

ahaeber opened this issue Sep 24, 2015 · 9 comments · Fixed by #127

Comments

@ahaeber
Copy link

ahaeber commented Sep 24, 2015

Gitlab 8.0 integrates Gitlab CI inside Gitlab. One crucial change for this plugin is that the URL setting has been removed so we can no longer configure the Gitlab CI service to point to Jenkins.

I believe we need a separate Jenkins integration service for Gitlab now. See documentation at https://gitlab.com/gitlab-org/gitlab-ce/tree/master/doc/integration. A starting point could be the previous version of the Gitlab CI service (from tag 7.14.3): https://gitlab.com/gitlab-org/gitlab-ce/blob/d321305c00f934db9becac1aa9726c3e9b400df5/app/models/project_services/gitlab_ci_service.rb

See also https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/project_services/ci_service.rb

@sgrassie
Copy link

I came here to post this. If I'd have known, I wouldn't have upgraded to 8.0.

To be fair to the plugin, it isn't fair to say that the plugin itself is broken :)

@atropo
Copy link

atropo commented Sep 29, 2015

I can still use this plugin in Gitlab > 8.0 by using only the web hook on push events.

@sgrassie
Copy link

@atropo Thanks for pointing that out, I'd forgotten all about web hooks completely.

@disengaged
Copy link

@atropo When only using web hooks, I guess you cannot get the build status icon and links on the merge request page?

@bassrock
Copy link
Contributor

Looks like they added some documentation specifically for our plugin. We won't be able to get the commit status until version 8.1

https://about.gitlab.com/2015/09/22/gitlab-8-0-released/

@bassrock bassrock changed the title Plugin broken on Gitlab 8.0 GitLab 8.0 Commit Status Broken Oct 13, 2015
@bassrock bassrock added this to the 8.0 Compatibility milestone Oct 13, 2015
@ayufan
Copy link
Contributor

ayufan commented Oct 15, 2015

@bassrock

We recently implemented Commit Status API in GitLab. It will be shipped with 8.1 release on 22.10. Maybe you need any assistance to have it integrated in your plugin?

Best regards,
Kamil Trzciński
CI Lead, GitLab Inc.

@bassrock
Copy link
Contributor

@ayufan

More than happy to accept anyassitanceor accept any pull request! Especially from the people at GitLab!

@ayufan
Copy link
Contributor

ayufan commented Oct 15, 2015

@bassrock

Would be happy to do it, but I don't have enough knowledge to write Jenkins plugins. However, if anyone decides to pick the topic I'll guide and help with the API to get it done :)

@tomelfring
Copy link
Contributor

I'm currently writing something that implements the new gitlab 8.1 commit API. Currently I've got a draft which works with merge requests. After some minor fixes i'll make a pullrequest here so you can review it.
I'll continue the work so it will also work with normal pushes.

omehegan added a commit that referenced this issue Nov 11, 2015
Added support for the GitLab 8.1 commit API
exceed-alae pushed a commit to exceed-alae/gitlab-plugin that referenced this issue May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants