[JENKINS-68809] Topic repository listing should include forks by default #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsandell
approved these changes
Jun 30, 2022
|
@Dohbedoh To you see this as a bugfix or a feature/enhancement? For me it's a bit of a gray area :) |
|
I was thinking of it as a bug given the facts that the event mechanism considers forks, which is inconsistent |
jetersen
reviewed
Jul 13, 2022
| topics.forEach(ghRepositorySearchBuilder::topic); | ||
| ghRepositorySearchBuilder.q("org:" + getRepoOwner()); | ||
| context.getTopics().forEach(ghRepositorySearchBuilder::topic); | ||
| ghRepositorySearchBuilder.org(getRepoOwner()); |
There was a problem hiding this comment.
Thanks for updating this :)
I had put a pull request into github api a while ago
|
Looks like this resolves https://issues.jenkins.io/browse/JENKINS-68765 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JENKINS-68809: the recent Topic filter added does not include fork by default. Due to the default behavior of the Search API. It probably should given that there is now an
ExcludeForkedRepositoriesTrait.This PR add
fork:trueto the search unlessExcludeForkedRepositoriesTraitis added.Note: we could actually always add
fork:trueand let the API filter out the results. But by using the filter in the search query, we can ave on that computation.Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify
@jenkinsci/github-branch-source-plugin-developers