OkHttp3 #223

bitwiseman · 2019-05-02T02:08:04Z

okhttp3 3.12.12

jglick · 2019-05-02T16:55:40Z

@bitwiseman no need to upload plugin archives to Drive! And never hand out *-SNAPSHOT versions. Just fix the build here (currently seems broken by INFRA-2075, which can be worked around simply by closing & reopening), and then wait for JEP-305 deployment and you can just link people to Artifactory for download.

src/main/java/org/jenkinsci/plugins/github_branch_source/OkHttp3Connector.java

bitwiseman · 2019-05-02T20:40:31Z

@jglick Yes, if the build weren't breaking the incremental-release would be what I'd use. But it is, so ...

jglick · 2019-05-02T21:40:56Z

if the build weren't breaking

Well now it looks legit:

java.lang.UnsupportedOperationException: clientBuilder.sslSocketFactory(SSLSocketFactory) not supported on JDK 9+
	at okhttp3.internal.platform.Jdk9Platform.trustManager(Jdk9Platform.java:81)
	at okhttp3.internal.platform.Platform.buildCertificateChainCleaner(Platform.java:176)
	at okhttp3.OkHttpClient$Builder.sslSocketFactory(OkHttpClient.java:768)
	at org.jenkinsci.plugins.github_branch_source.OkHttp3Connector.<init>(OkHttp3Connector.java:40)
	at …

bitwiseman · 2019-05-02T22:55:14Z

@jglick Legit on java9+. This is still an early alpha experiment.

jglick · 2019-05-03T19:49:09Z

Legit on java9+.

FWIW I would then just patch Jenkinsfile in this PR to remove the Java 11 build configurations, so we at least get a clean build & Incrementals publishing on Java 8, and later figure out how to fix 11 compatibility before moving out of draft.

pom.xml

jsoref · 2019-05-07T16:58:56Z

So, I don't think that was sufficient, although I think it was necessary.

Dependencies and Class Loading suggests:
pluginFirstClassLoader and its discontents

pluginFirstClassLoader
maskClasses

I think the lazy choice is the former, which appears to look like this:
https://github.com/jenkinsci/hidden-parameter-plugin/blob/46b50d0747c748d84e8ccb40b7c9330813a31e84/pom.xml#L30-L37

jsoref · 2019-05-07T17:03:38Z

This PR is supposed to help fix JENKINS-54126

bitwiseman · 2019-05-08T20:20:45Z

@jsoref
I manually tested it this time on my local jenkins. Builds run. Scan runs.
https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/github-branch-source/2.5.3-rc841.52a0b90bff37/

bitwiseman · 2020-02-21T18:25:39Z

Most of the code that was in this change has been added to github-api and is tested in that library.

jsoref

Looks ok to me...

pom.xml

GitHubAppCredentials could not use the existing Connector.connect() and so created its own GithubBuilder. However, that means that is missing a number of standard settings provided by Connector.connect(), including okhttp, Jenkins proxy settings, and rate limit handling. This change refactors Connector to add an internal createGitHubBuilder() method that returns a GitHubBuilder with those features configured. For simplicity, The returned GitHubBuilder is not cached and also does not cache responses. If there turns out to be a need for it, that behavior can be added later.

dwnusbaum

Changes look good, but there are some test failures that don't make sense to me:

java.lang.Error: Plugin github-api failed to start
...
Caused by: java.io.IOException: GitHub API Plugin version 1.111.4 failed to load.

You must update Jenkins from version 2.164.1 to version 2.164.3 or later to run this plugin.

This plugin already depends on 2.164.3, same as GitHub API Plugin 1.111.4, so I'm not sure what's happening here.

bitwiseman · 2020-06-03T21:43:28Z

@dwnusbaum It's the jenkinsfile build configurations.

bitwiseman · 2020-06-03T22:54:12Z

@timja I updated GitHubAppCredentials to use okhttp. Does this look good to you?

timja · 2020-06-04T06:22:39Z

Jenkinsfile

+buildPlugin(configurations: [
+    [ platform: "linux", jdk: "8"],
+    [ platform: "windows", jdk: "8"],
+    [ platform: "linux", jdk: "11", jenkins: "2.176.4", javaLevel: "8" ]


Any reason you aren’t testing a more recent lts here?

Trying to keep things simple-ish in this PR.

timja · 2020-06-10T08:28:47Z

Created https://issues.jenkins-ci.org/browse/JENKINS-62652 for "A connection to https://api.github.com/ was leaked. Did you forget to close a response body?"

timja · 2020-06-10T11:32:55Z

also:
https://issues.jenkins-ci.org/browse/JENKINS-62655

IllegalStateException: Jenkins has not been started, or was already shut down

jglick reviewed May 2, 2019

View reviewed changes

src/main/java/org/jenkinsci/plugins/github_branch_source/OkHttp3Connector.java Outdated Show resolved Hide resolved

bitwiseman force-pushed the okhttp3 branch from 451aeb8 to 126837c Compare May 2, 2019 20:41

jsoref reviewed May 3, 2019

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

bitwiseman force-pushed the okhttp3 branch from 126837c to 6594cf5 Compare May 6, 2019 20:30

bitwiseman force-pushed the okhttp3 branch from bde3573 to d4b76c5 Compare May 8, 2019 19:56

bitwiseman force-pushed the okhttp3 branch 2 times, most recently from aa94134 to 52a0b90 Compare May 8, 2019 20:55

bitwiseman force-pushed the okhttp3 branch from 52a0b90 to b58a1ba Compare May 24, 2019 14:42

bitwiseman force-pushed the okhttp3 branch from 0a8e1fb to 88809bd Compare September 10, 2019 21:15

bitwiseman force-pushed the okhttp3 branch from 00200ea to 8c0e7a4 Compare September 20, 2019 18:14

bitwiseman requested a review from jsoref February 21, 2020 18:24

jsoref reviewed Feb 21, 2020

View reviewed changes

bitwiseman closed this Feb 23, 2020

bitwiseman reopened this Feb 24, 2020

bitwiseman closed this Feb 24, 2020

bitwiseman reopened this Feb 24, 2020

bitwiseman force-pushed the okhttp3 branch 2 times, most recently from a5c4f37 to 5bac543 Compare May 1, 2020 20:08

bitwiseman commented May 4, 2020

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

bitwiseman force-pushed the okhttp3 branch 2 times, most recently from e2163c3 to a5716d0 Compare June 2, 2020 04:04

bitwiseman marked this pull request as ready for review June 2, 2020 04:07

bitwiseman force-pushed the okhttp3 branch 2 times, most recently from ecde54c to f73096b Compare June 2, 2020 22:39

bitwiseman added 2 commits June 3, 2020 13:53

Switch to using okhttp3

d8b2c8a

bitwiseman force-pushed the okhttp3 branch from f73096b to 342952d Compare June 3, 2020 21:02

dwnusbaum reviewed Jun 3, 2020

View reviewed changes

Move to locally controlled build configs

8378bbe

bitwiseman requested review from dwnusbaum and timja June 3, 2020 22:42

timja approved these changes Jun 4, 2020

View reviewed changes

kshultzCB approved these changes Jun 4, 2020

View reviewed changes

bitwiseman merged commit b012689 into jenkinsci:master Jun 4, 2020

jglick mentioned this pull request Jun 10, 2020

[JENKINS-62655] IllegalStateException caused by misuse of Jenkins.instance from an agent JVM #308

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OkHttp3 #223

OkHttp3 #223

bitwiseman commented May 2, 2019 •

edited

Loading

jglick commented May 2, 2019

bitwiseman commented May 2, 2019

jglick commented May 2, 2019

bitwiseman commented May 2, 2019

jglick commented May 3, 2019

jsoref commented May 7, 2019

jsoref commented May 7, 2019

bitwiseman commented May 8, 2019 •

edited

Loading

bitwiseman commented Feb 21, 2020

jsoref left a comment

dwnusbaum left a comment

bitwiseman commented Jun 3, 2020

bitwiseman commented Jun 3, 2020

timja Jun 4, 2020

bitwiseman Jun 4, 2020

timja commented Jun 10, 2020

timja commented Jun 10, 2020

OkHttp3 #223

OkHttp3 #223

Conversation

bitwiseman commented May 2, 2019 • edited Loading

jglick commented May 2, 2019

bitwiseman commented May 2, 2019

jglick commented May 2, 2019

bitwiseman commented May 2, 2019

jglick commented May 3, 2019

jsoref commented May 7, 2019

jsoref commented May 7, 2019

bitwiseman commented May 8, 2019 • edited Loading

bitwiseman commented Feb 21, 2020

jsoref left a comment

Choose a reason for hiding this comment

dwnusbaum left a comment

Choose a reason for hiding this comment

bitwiseman commented Jun 3, 2020

bitwiseman commented Jun 3, 2020

timja Jun 4, 2020

Choose a reason for hiding this comment

bitwiseman Jun 4, 2020

Choose a reason for hiding this comment

timja commented Jun 10, 2020

timja commented Jun 10, 2020

bitwiseman commented May 2, 2019 •

edited

Loading

bitwiseman commented May 8, 2019 •

edited

Loading