-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest github-api 1.99 #24
Conversation
Also update to latest Jackson2 API
okio v2 is api and binary compatible with v1. https://square.github.io/okio/changelog/ okio 1.6.0 that is included with OkHttp2 is over four years old.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per #24 (comment) you need to either reintroduce JenkinsRule
, or simply update jenkins.version
.
@bitwiseman @KostyaSha FYI GitHub API 1.99+ requires commons codec 1.13 due to hub4j/github-api#551 . It is above the version used by the Jenkins core, but you do not get an error during the exclusion: https://github.com/jenkinsci/github-api-plugin/blob/master/pom.xml#L77-L80 . Same applies to other exclusions. I am putting the new GitHub API Plugin release on hold, because there is a non-zero chance of nuking the GitHub plugin ecosystem by this release. I suggest reviewing it after DW-JW |
This pull request cannot be reverted automatically. I suggest doing it manually so that we do not keep the potentially explosive version in the master branch. WDYT @bitwiseman ? Also CC @batmat |
Also update to latest Jackson2 API and Okio.
Okio 2 is binary compatible with 1.x.