Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version 1.92 of the org.kohsuke.github-api artifact #19

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Use version 1.92 of the org.kohsuke.github-api artifact #19

merged 1 commit into from
Jun 5, 2018

Conversation

kodeva
Copy link
Contributor

@kodeva kodeva commented Jan 18, 2018

The version 1.90 throws an exception when parsing pull request review with the state "CHANGES_REQUESTED"

com.fasterxml.jackson.databind.exc.InvalidFormatException: Can not construct instance of org.kohsuke.github.GHPullRequestReviewState from String value ("CHANGES_REQUESTED"): value not one of declared Enum instance names: [DISMISSED, REQUEST_CHANGES, COMMENTED, PENDING, APPROVED]

The version 1.90 throws an exception when parsing pull request review with the state "CHANGES_REQUESTED"

com.fasterxml.jackson.databind.exc.InvalidFormatException: Can not construct instance of org.kohsuke.github.GHPullRequestReviewState from String value ("CHANGES_REQUESTED"): value not one of declared Enum instance names: [DISMISSED, REQUEST_CHANGES, COMMENTED, PENDING, APPROVED]
@kodeva
Copy link
Contributor Author

kodeva commented Jan 19, 2018

Hi @jglick, @stephenc.
The issue in processing CHANGES_REQUESTED review state in the older org.kohsuke.github-api lib (1.90) is blocking us a bit. Could you please add appropriate reviewers?
Would it be please possible to release a new version of the github-api-plugin soon?
Thank you!
Stepan Hrbacek, SolarWinds

@liborbitala
Copy link

Hello @jglick, @stephenc ,
would it be possible to proceed with this pull request? We are having issues related to this one hub4j/github-api#395 and using GitHub API v1.92 would help us a lot.
Could you please add your reviews and release new version?
Thank you very much.

@papezt
Copy link

papezt commented Feb 26, 2018

Hi guys, I would appreciate this PR merged as well. Thanks, Tomas

@ezyang
Copy link

ezyang commented Mar 14, 2018

Yes, would love to have the null pointer GHPerson fix. Thanks!

@ezyang
Copy link

ezyang commented Mar 15, 2018

Here's a Maven build of this PR which you can upload to your Jenkins instance, courtesy of @prigoyal

github-api-1.91-SNAPSHOT.hpi.zip

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a maintainer of this and have no opinion.

@jglick jglick requested review from abayer, rsandell and svanoort March 28, 2018 16:44
Copy link
Member

@abayer abayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I guess? I'm not a maintainer here either, as far as I'm aware. =)

@oleg-nenashev
Copy link
Member

Yes. Somebody needs to 🚢 🇮🇹

@oleg-nenashev
Copy link
Member

@MichaelManz
Copy link

@rsandell We are blocked by this as well, please 🚢 💐

@KostyaSha
Copy link
Member

Waiting for half year.
@jglick if you are not a maintainer, how did you make releases before?

@@ -36,7 +36,7 @@
<dependency>
<groupId>org.kohsuke</groupId>
<artifactId>github-api</artifactId>
<version>1.90</version>
<version>1.92</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest release is 1.93

version is line 19 also has to be adjusted

Copy link
Member

@KostyaSha KostyaSha May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded, during release process release artifact is aligned, snapshot versions are not critical.

@oleg-nenashev
Copy link
Member

oleg-nenashev commented May 29, 2018

@KostyaSha you are in the list of maintainers in Repository Permission Updater. So you can merge the PR and ship the release on your own if needed.

@KostyaSha
Copy link
Member

KostyaSha commented May 29, 2018

@oleg-nenashev my maintainership was "hijacked" (see release history), i don't want maintain again when somebody will do unreviewed merges, adding unneeded dependencies. Except 2 persons this list contains CB people. Does CB maintain this library? If not, then i will do release and revoke perms.

@KostyaSha KostyaSha merged commit d028b0d into jenkinsci:master Jun 5, 2018
@dirk-thomas
Copy link

dirk-thomas commented Jun 6, 2018

As mentioned in this commit releasing this fix if blocked on the availability of jackson2-api 2.9.x.

@dirk-thomas
Copy link

@KostyaSha A new version (even though labeled beta) of jackson2-api has been released: 2.9.7.0-beta (Oct 8, 2018) which provides Jackson 2.9.7.

@KostyaSha
Copy link
Member

i see, will make beta and test

@dirk-thomas
Copy link

Is this beta release available somewhere to give it a try? Or what is the timeline for becoming available as a normal version?

@KostyaSha
Copy link
Member

Please stop commenting here, there is PR.

@dirk-thomas
Copy link

dirk-thomas commented Oct 18, 2018

there is PR.

For future readers: #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.