-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use version 1.92 of the org.kohsuke.github-api artifact #19
Conversation
The version 1.90 throws an exception when parsing pull request review with the state "CHANGES_REQUESTED" com.fasterxml.jackson.databind.exc.InvalidFormatException: Can not construct instance of org.kohsuke.github.GHPullRequestReviewState from String value ("CHANGES_REQUESTED"): value not one of declared Enum instance names: [DISMISSED, REQUEST_CHANGES, COMMENTED, PENDING, APPROVED]
Hi @jglick, @stephenc. |
Hello @jglick, @stephenc , |
Hi guys, I would appreciate this PR merged as well. Thanks, Tomas |
Yes, would love to have the null pointer GHPerson fix. Thanks! |
Here's a Maven build of this PR which you can upload to your Jenkins instance, courtesy of @prigoyal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a maintainer of this and have no opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I guess? I'm not a maintainer here either, as far as I'm aware. =)
Yes. Somebody needs to 🚢 🇮🇹 |
@rsandell We are blocked by this as well, please 🚢 💐 |
Waiting for half year. |
@@ -36,7 +36,7 @@ | |||
<dependency> | |||
<groupId>org.kohsuke</groupId> | |||
<artifactId>github-api</artifactId> | |||
<version>1.90</version> | |||
<version>1.92</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest release is 1.93
version is line 19 also has to be adjusted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unneeded, during release process release artifact is aligned, snapshot versions are not critical.
@KostyaSha you are in the list of maintainers in Repository Permission Updater. So you can merge the PR and ship the release on your own if needed. |
@oleg-nenashev my maintainership was "hijacked" (see release history), i don't want maintain again when somebody will do unreviewed merges, adding unneeded dependencies. Except 2 persons this list contains CB people. Does CB maintain this library? If not, then i will do release and revoke perms. |
As mentioned in this commit releasing this fix if blocked on the availability of |
@KostyaSha A new version (even though labeled beta) of |
i see, will make beta and test |
Is this beta release available somewhere to give it a try? Or what is the timeline for becoming available as a normal version? |
Please stop commenting here, there is PR. |
For future readers: #20. |
The version 1.90 throws an exception when parsing pull request review with the state "CHANGES_REQUESTED"
com.fasterxml.jackson.databind.exc.InvalidFormatException: Can not construct instance of org.kohsuke.github.GHPullRequestReviewState from String value ("CHANGES_REQUESTED"): value not one of declared Enum instance names: [DISMISSED, REQUEST_CHANGES, COMMENTED, PENDING, APPROVED]