[JENKINS-63539] Expand repo cache lookup for better size estimates

[rishabhBudhouliya]

JENKINS-63539 - Expand repo cache lookup for better size estimates

Extend the cache lookup process to better use the cached copies.

• An in-memory cache that uses a canonical repository URL as its key and stores the repo size
• A lookup method which takes the repository URL, converts it into the canonical form and then finds it in the internal cache
• A cache assignment method which takes the repository URL, converts it to normalized repository URL format, then stores the size of the repository if the size is larger than the size (optionally) stored in that cache entry already
• Look at the internal cache before looking for stored cache in Jenkins.

Note: To avoid potential confusion between the GitToolChooser in-memory cache and the Jenkins cache directory, I have used the term internal-cache for the in-memory GitToolChooser cache. We could also name it in-memory cache if you find that more suitable.

Checklist

• I have read the CONTRIBUTING doc
• I have referenced the Jira issue related to my changes in one or more commit messages
• I have added tests that verify my changes
• Unit tests pass locally with my changes
• I have added documentation as necessary
• No Javadoc warnings were introduced with my changes
• No spotbugs warnings were introduced with my changes
• I have interactively tested my changes
• Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Further comments

I need to clean/simplify the code, right now it contains duplicated code (most from @MarkEWaite's PR-947).

[rishabhBudhouliya]

@MarkEWaite Thanks for doing the great work on PR-947. I have rearranged some of the components as discussed. Apologies for taking too much time.

[MarkEWaite]

This may seem like a strange request, but the output of git log --pretty=oneline --abbrev-commit --decorate is badly broken when there is not an empty line between the first line of the commit message (the summary, recommend 50 characters or less) and the body of the commit message.

Could you do a git commit --amend to modify this commit message so that there is a blank line between the first line and the rest of the message? Once you've amended the commit, then you'll need to force the push with git push --force.

I almost never ask someone to modify a commit message, but this is one of those cases where the output is much harder to read due to the absence of that blank line

[MarkEWaite]

This looks great! Thanks for your good work @rishabhBudhouliya !

Could you review my comments and consider them?

[MarkEWaite]

I've added some other cosmetic comments in the form of optional commits to my copy of this branch. Refer to https://github.com/MarkEWaite/git-plugin/commits/JENKINS-63539 to decide if you'd like to include any of them in the pull request. Any that I considered strongly needed are already mentioned in the comments on this pull request.

[rishabhBudhouliya]

@MarkEWaite Many thanks on the further review, I have added your suggestions + one test on the process of normalisation of alternate remote URLs to the standard URL.

I will look at the other comments on your fork and try to add them as well.

[MarkEWaite]

This looks great. Thanks @rishabhBudhouliya . I'll do further interactive testing with the latest build from ci.jenkins.io. I hope to merge the change and release a new git plugin version with the changes this weekend.