Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch IOException by printCommitMessageToLog #957

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

auselen
Copy link
Contributor

@auselen auselen commented Sep 17, 2020

It is possible that node running git operation is having memory issues and frequently fail
with a stack trace similar to below. Since printCommitMessageToLog is considered informational
avoid such issues.

09:28:57 java.lang.OutOfMemoryError: Java heap space
09:28:57 Caused: java.io.IOException: Remote call on XXXX failed
09:28:57 at hudson.remoting.Channel.call(Channel.java:1007)
09:28:57 at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInv=
ocationHandler.java:286)
09:28:57 at com.sun.proxy.$Proxy82.withRepository(Unknown Source)
09:28:57 at org.jenkinsci.plugins.gitclient.RemoteGitImpl.withReposi=
tory(RemoteGitImpl.java:237)
09:28:57 at hudson.plugins.git.GitSCM.printCommitMessageToLog(GitSCM=
.java:1347)
09:28:57 at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1316)
09:28:57 at org.jenkinsci.plugins.multiplescms.MultiSCM.checkout(Mul=
tiSCM.java:143)
09:28:57 at hudson.scm.SCM.checkout(SCM.java:505)
09:28:57 at hudson.model.AbstractProject.checkout(AbstractProject.ja=
va:1206)
09:28:57 at hudson.model.AbstractBuild$AbstractBuildExecution.defaul=
tCheckout(AbstractBuild.java:574)
09:28:57 at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStra=
tegy.java:86)
09:28:57 at hudson.model.AbstractBuild$AbstractBuildExecution.run(Ab=
stractBuild.java:499)
09:28:57 at hudson.model.Run.execute(Run.java:1894)
09:28:57 at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
09:28:57 at hudson.model.ResourceController.execute(ResourceControll=
er.java:97)
09:28:57 at hudson.model.Executor.run(Executor.java:428)

JENKINS-xxxxx - summarize pull request in one line

Describe the big picture of your changes here to explain to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, include a link to the issue.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code. If a checkbox or line does not apply to this pull request, delete it. We prefer all checkboxes to be checked before a pull request is merged

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. Delete the items in the list that do not apply

  • Dependency or infrastructure update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Further comments

If this is a relatively large or complex change, start the discussion by explaining why you chose the solution you did and what alternatives you considered.

It is possible that node running git operation is having memory issues and frequently fail
with a stack trace similar to below. Since printCommitMessageToLog is considered informational
avoid such issues.

09:28:57 java.lang.OutOfMemoryError: Java heap space
09:28:57 Caused: java.io.IOException: Remote call on XXXX failed
09:28:57        at hudson.remoting.Channel.call(Channel.java:1007)
09:28:57        at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInv=
ocationHandler.java:286)
09:28:57        at com.sun.proxy.$Proxy82.withRepository(Unknown Source)
09:28:57        at org.jenkinsci.plugins.gitclient.RemoteGitImpl.withReposi=
tory(RemoteGitImpl.java:237)
09:28:57        at hudson.plugins.git.GitSCM.printCommitMessageToLog(GitSCM=
.java:1347)
09:28:57        at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1316)
09:28:57        at org.jenkinsci.plugins.multiplescms.MultiSCM.checkout(Mul=
tiSCM.java:143)
09:28:57        at hudson.scm.SCM.checkout(SCM.java:505)
09:28:57        at hudson.model.AbstractProject.checkout(AbstractProject.ja=
va:1206)
09:28:57        at hudson.model.AbstractBuild$AbstractBuildExecution.defaul=
tCheckout(AbstractBuild.java:574)
09:28:57        at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStra=
tegy.java:86)
09:28:57        at hudson.model.AbstractBuild$AbstractBuildExecution.run(Ab=
stractBuild.java:499)
09:28:57        at hudson.model.Run.execute(Run.java:1894)
09:28:57        at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
09:28:57        at hudson.model.ResourceController.execute(ResourceControll=
er.java:97)
09:28:57        at hudson.model.Executor.run(Executor.java:428)
@MarkEWaite MarkEWaite added the bugfix Fixes a bug - used by Release Drafter label Sep 17, 2020
@MarkEWaite MarkEWaite merged commit a306da6 into jenkinsci:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants