Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamcrest assertions, more tests, consistent formatting #955

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Hamcrest assertions, more tests, consistent formatting #955

merged 1 commit into from
Sep 13, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Sep 13, 2020 •
edited
Loading

Hamcrest assertions, more tests, consistent formatting

Use hamcrest assertions for clarity

Spelling fixes for method names

Use consistent white space

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Dependency or infrastructure update

@MarkEWaite
Hamcrest asseertions, more tests, consistent formatting
ecf855d 
Use hamcrest assertions for clarity

Spelling fixes for method names

Use consistent white space

Add 3 more tests of DefaultBuildChooser
@MarkEWaite MarkEWaite merged commit fd34746 into jenkinsci:master Sep 13, 2020
@MarkEWaite MarkEWaite deleted the JENKINS-37263-add-tests branch September 13, 2020 13:11
@MarkEWaite MarkEWaite changed the title Hamcrest asseertions, more tests, consistent formatting Hamcrest assertions, more tests, consistent formatting Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite