Reduce test warning count by not using Assume #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maven surefire plugin reports skipped tests as a WARNING. That WARNING causes the warnings plugin on ci.jenkins.io to count the skipped test as a warning and display the warning in the job results. The tests are intentionally skipped so they should not be counted as warnings. This converts the assertion from a warning to no warning. The same code is executed as previously, without the maven surefire warning. The change also converts a few locations to consistently use the same isWindows() function as is used elsewhere in the code.
Either it works or it is deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce test warning count by not using Assume
The maven surefire plugin reports skipped tests as a WARNING. That WARNING causes the warnings plugin on ci.jenkins.io to count the skipped test as a warning and display the warning in the job results.
The tests are intentionally skipped so they should not be counted as warnings. This converts the assertion from a warning to no warning. The same code is executed as previously, without the maven surefire warning.
The change also converts a few locations to consistently use the same isWindows() function as is used elsewhere in the code.
Describe the big picture of your changes here to explain to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, include a link to the issue.
Checklist
Types of changes