[JENKINS-63541] Don't create empty dirs in chooser #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git plugin previously created an empty directory in the $JENKINS_HOME/caches directory for any repository URL that it checked for size. Those empty directories are not likely to use too much disc space, but a large installation that clones many different repositories will have many empty directories in the caches directory. Provides a new getCacheDir API that returns null if the directory does not already exist.
MarkEWaite
force-pushed
the
no-empty-dirs-on-cache-lookup
branch
from
5f897a0 to
2cf7ef7
Compare
11 tasks
rishabhBudhouliya
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Thanks for catching this issue, I had completely forgotten that getCacheDir creates a new directory every time we try to look for one.
I was only concerned of breaking the existing behaviour as the Multi branch project depends on this API but you've taken care of that as well, overall looks great to me.
fcojfernandez
approved these changes
Aug 28, 2020
|
Really good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-63541 - Don't create empty dirs in chooser
The git plugin previously created an empty directory in the $JENKINS_HOME/caches directory for any repository URL that it checked for size. Those empty directories are not likely to use too much disc space, but a large installation that clones many different repositories will have many empty directories in the caches directory.
Provides a new getCacheDir API that returns null if the directory does not already exist.
Checklist
Types of changes