Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve deprecations in main #899

Merged
merged 37 commits into from
Jun 5, 2020
Merged

Resolve deprecations in main #899

merged 37 commits into from
Jun 5, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented May 26, 2020 •
edited
Loading

Resolve Java deprecation messages in main, many in tests

Replace calls to deprecated main methods with their replacement methods or mark the calling method deprecated as appropriate.

Replace calls to several deprecated test methods with their replacement methods or mark the calling method deprecated as appropriate.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Refactoring

Further comments

All the changes are intended to be behavior preserving refactors.

MarkEWaite added 30 commits May 26, 2020 14:13
@MarkEWaite
Enable deprecation warnings from java compiler
c6fabb1
@MarkEWaite
Use try/finally in GitChangeLogParser
8072caa
@MarkEWaite
Use PerBuildTag instead of deprecated getSkipTag()
c4d9d70
@MarkEWaite
Use non-deprecated GitLab constructor
0d3590a
@MarkEWaite
Use non-deprecated methods in GitSCM
579b59d
@MarkEWaite
Use non-deprecated checkout in SubmoduleCombinator
c5316de
@MarkEWaite
Use buildEnvironment instead of deprecated buildEnvVars
d89270a
@MarkEWaite
Suppress deprecation warnings
48e65a7
@MarkEWaite
Deprecate because overrides deprecated method
ecac6eb
@MarkEWaite
Suppress IGitAPI deprecation warnings
70ed0c6
@MarkEWaite
Suppress getRepository reference in AbstractGitSCMSource
c440e74
@MarkEWaite
Suppress warnings on index triggering
d3fac2d
@MarkEWaite
Use emptyString in hamcrest assertion
82f345c
@MarkEWaite
Deprecate tests of deprecated methods
0865e84 
Silence deprecation warnings
@MarkEWaite
Suppress test deprecation warnings for getRepository
b8d7df9
@MarkEWaite
Suppress deprecation message on getBuilds.size()
c448d02
@MarkEWaite
Test with readLines and character set
8c6b433
@MarkEWaite
Use non-deprecated getLog(n) method
b805610
@MarkEWaite
Use getSomeWorkspace in test, not deprecated getWorkspace
3328cdc 
The caller has only built one time in the workspace so "some"
workspace can only be the single build that was run.
@MarkEWaite
Test with non-deprecated User.get() replacement
0353114
@MarkEWaite
Use data bound setter instead of deprecated SCMTrigger constructor
2422c7d
@MarkEWaite
Deprecate test of deprecated method
37bd53e
@MarkEWaite
Use non-deprecated getWorkspace().getRemote()
f0739cd
@MarkEWaite
Use non-deprecated IOUtils.toString()
964a767
@MarkEWaite
Mark a UserMergeOptions test method as deprecated
6785e52
@MarkEWaite
Deprecate an assert method that depends on a deprecated method
ccc54f6
@MarkEWaite
Call non-deprecated repo browser constructor
1943cf9
@MarkEWaite
Mark two methods as Overriden
4626c4a
@MarkEWaite
Fix compile of GitRepositoryBrowserImpl in test
d685a3f
@MarkEWaite
Test with Cause.UserIdCause(), not deprecated Cause.UserCause()
aac2d51 
Deprecation happened in 1.427, a very long time ago.
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch from c59eb71 to 6863f10 Compare May 30, 2020 20:29
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Jun 4, 2020
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch 2 times, most recently from 3e2304a to 5d3033c Compare June 4, 2020 10:43
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch 4 times, most recently from 3d8d253 to a126b0c Compare June 4, 2020 11:16
@MarkEWaite
Don't let dirty workspace fail incremental build
b279163 
Once jenkins-infra/pipeline-library#141 is merged,
the calls to `clean` can be removed.
@MarkEWaite MarkEWaite force-pushed the reduce-deprecation-warnings branch from a126b0c to b279163 Compare June 4, 2020 11:20
@MarkEWaite MarkEWaite merged commit a3d4ec8 into jenkinsci:master Jun 5, 2020
@MarkEWaite MarkEWaite deleted the reduce-deprecation-warnings branch June 5, 2020 01:44
@jglick jglick mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite