Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-62183] Allow user with Jenkins.MANAGE to access global config #896

Merged
merged 4 commits into from
May 26, 2020
Merged

[JENKINS-62183] Allow user with Jenkins.MANAGE to access global config #896

merged 4 commits into from
May 26, 2020

Conversation

mikecirioli
Copy link
Contributor

@mikecirioli mikecirioli commented May 18, 2020 •
edited by MarkEWaite
Loading

JENKINS-62183 - Allow user with Jenkins.MANAGE permission to access global config for the git plugin

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • New feature (non-breaking change which adds functionality)

@MarkEWaite MarkEWaite changed the title Allow user with Jenkins.MANAGE permission to access global config Allow user with Jenkins.MANAGE to access global config May 18, 2020
MarkEWaite
MarkEWaite requested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the jsr-305 annotations changed.

Needs to use Jenkins 2.204.1 if at all possible.

pom.xml Outdated Show resolved Hide resolved
src/test/java/hudson/plugins/git/GitSCMTest.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/git/GitSCM.java Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/git/GitSCM.java Outdated Show resolved Hide resolved
src/test/java/hudson/plugins/git/GitSCMTest.java Show resolved Hide resolved
MarkEWaite and others added 3 commits May 18, 2020 15:13
@MarkEWaite
Use spotbugs annotations
7684bc0 
JSR-305 annotations have been removed from the plugin
@mikecirioli @MarkEWaite
use isEmpty()
8ee221d 
Co-authored-by: Mark Waite <[email protected]>
@mikecirioli
revert back to using older jenkins baseline and modify permission checks
072e6e7 
to use reflection
@MarkEWaite MarkEWaite changed the title Allow user with Jenkins.MANAGE to access global config [JENKINS-62183] Allow user with Jenkins.MANAGE to access global config May 19, 2020
@mikecirioli mikecirioli reopened this May 19, 2020
@mikecirioli mikecirioli reopened this May 19, 2020
@mikecirioli
Copy link
Contributor Author

@MarkEWaite Ready for review again

fcojfernandez
fcojfernandez approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@fcojfernandez fcojfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test successfully executed forcing -Djenkins.version=2.224

src/test/java/hudson/plugins/git/GitSCMTest.java Show resolved Hide resolved
@fcojfernandez fcojfernandez requested a review from MarkEWaite May 20, 2020 08:15
@mikecirioli mikecirioli reopened this May 26, 2020
@mikecirioli mikecirioli reopened this May 26, 2020
@MarkEWaite MarkEWaite merged commit 7b34da2 into jenkinsci:master May 26, 2020
@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcojfernandez fcojfernandez fcojfernandez approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@rsandell rsandell Awaiting requested review from rsandell

Assignees
No one assigned
Labels
enhancement Improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecirioli @MarkEWaite @fcojfernandez