Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on Japanese translation #882

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Fix typo on Japanese translation #882

merged 1 commit into from
Apr 18, 2020

Conversation

nishidayuya
Copy link
Contributor

@nishidayuya nishidayuya commented Apr 18, 2020 •
edited
Loading

Fix typo on Japanese translation

I applied s/ワルドカード/ワイルドカード/g.

I have checked no ワルドカード under fixed commit. below:

$ git rev-parse HEAD
e533614dd10592695da8c0861ef203900fcdf344
$ git grep -n ワルドカード | wc -l
0

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • No spotbugs warnings were introduced with my changes

Types of changes

Only fix typo

  • Bug fix (non-breaking change which fixes an issue)

MarkEWaite
MarkEWaite approved these changes Apr 18, 2020
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google translate confirms the change is an improvement. Thanks very much!

@MarkEWaite MarkEWaite added the bugfix Fixes a bug - used by Release Drafter label Apr 18, 2020
@MarkEWaite MarkEWaite merged commit 0601fe5 into jenkinsci:master Apr 18, 2020
@nishidayuya
Copy link
Contributor Author

Thank you for your quickly responses! 🎉

@nishidayuya nishidayuya deleted the fix_typo branch April 19, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res0nance res0nance res0nance approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bugfix Fixes a bug - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nishidayuya @MarkEWaite @res0nance