Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more prune stale tags tests #875

Merged
merged 3 commits into from
Apr 18, 2020

Conversation

MarkEWaite
Copy link
Contributor

Add more tests of PruneStaleTags

New feature that will be released in git plugin 4.3.0. I'd like to have better test coverage in new features than we have in existing features. These tests cover the equals contract, the hashCode implementation, and the toString() implementation. They do not attempt to cover the missed branches from the tests that were created during development.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes

Types of changes

  • New feature test

Initialized in the constructor and never modified.
Simplifies the equals contract by not including mutable fields in
the equals calculation.
The toString method should represent the state of the object.
Cover the equals, hashCode, and toString methods.
@MarkEWaite MarkEWaite requested a review from nfalco79 April 14, 2020 16:08
@MarkEWaite MarkEWaite merged commit aa09dfd into jenkinsci:master Apr 18, 2020
@MarkEWaite MarkEWaite deleted the add-prune-stale-tags-tests branch April 18, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant