Add tests for SparseCheckoutPaths, remove dead code #872

MarkEWaite · 2020-04-13T01:21:42Z

Remove dead code from SparseCheckoutPaths

Add tests to support dead code removal from SparseCheckoutPaths.

I have read the CONTRIBUTING doc
I have referenced the Jira issue related to my changes in one or more commit messages
I have added tests that verify my changes
Unit tests pass locally with my changes
I have added documentation as necessary
No Javadoc warnings were introduced with my changes
No spotbugs warnings were introduced with my changes
I have interactively tested my changes
Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Java lang package imports are not required.

Value is defined in constructor and never modified.

Javadoc and all implementations confirmed as no-op.

MarkEWaite added 4 commits April 12, 2020 19:13

Remove unneccesary import of java.lang.Thread

c2add52

Java lang package imports are not required.

Make sparseCheckouts private field final

fd0c8da

Value is defined in constructor and never modified.

Remove no-op deprecated call to noCheckout()

06dbaf9

Javadoc and all implementations confirmed as no-op.

Add SparseCheckoutPaths tests

59c156e

MarkEWaite added the test label Apr 13, 2020

MarkEWaite merged commit bb5832a into jenkinsci:master Apr 13, 2020

MarkEWaite deleted the add-tests branch April 13, 2020 03:49