Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce spotbugs warnings #871

Merged
merged 6 commits into from
Apr 13, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Apr 12, 2020

Reduce spotbugs warnings

A recent settings change increased the number of spotbugs warnings by allowing higher effort and a lower threshold. Resolve several spotbugs warnings that are easy to resolve.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Refactoring to remove warnings

@MarkEWaite MarkEWaite merged commit c932d8e into jenkinsci:master Apr 13, 2020
@MarkEWaite MarkEWaite deleted the reduce-spotbugs-warnings branch April 13, 2020 01:04
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant