Use waitForMessage instead of assertLogContains #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse Glick noted that some flaky pipeline tests in other plugins could be resolved by switching from assertLogContains to waitForMessage. Since the git plugin has shown a tendency to flaky tests on Windows, let's use Jesse's recommendation as well. See jenkinsci/bom#110 (comment)
Easier to diagnose a failure if the assertion describes the expectation
Wait briefly for newly scheduled job to start. Once job has started, waitForAllJobsToComplete will hold the test until job completes. Windows can remove log files once job completes. Wait on non-Windows reduces log file InterruptedException from rule teardown before job completion. Wait on non-Windows not strictly required but gives one less exception in the test log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use waitForMessage instead of assertLogContains
Jesse Glick noted in a comment that some flaky pipeline tests in other plugins could be resolved by switching from assertLogContains to waitForMessage. Since the git plugin has shown a tendency to flaky tests on Windows, let's use Jesse's recommendation as well.
Checklist
Types of changes