JENKINS-55787 Switch labels from entry to checkbox

[timja]

JENKINS-55787 - Switch labels from entry to checkbox

2.227-SNAPSHOT

2.138.4

You can also test via reverting my revert jenkins core version commit

ref: jenkinsci/jenkins#3895, cc @MarkEWaite @jsoref

Checklist

• I have read the CONTRIBUTING doc
• I have referenced the Jira issue related to my changes in one or more commit messages
• Unit tests pass locally with my changes
• I have added documentation as necessary
• No Javadoc warnings were introduced with my changes
• No spotbugs warnings were introduced with my changes
• I have interactively tested my changes

Types of changes

• Bug fix (non-breaking change which fixes an issue)

[jsoref]

This supercedes #676

[romenrg]

I'm not very familiar with this, but here are my two cents:

Just tested this locally and it seems to work fine, although my UI looks slightly different to what I see in the PR description by @timja (I'm probably missing something):

From @jsoref comment and linked PR I understand the idea is to have attributes associated to the checkbox rather than to the entry.

Taking a look at the resulting html, I see this code:

Which seems to come from this change:

I wonder if this is the expected result. Maybe it is, just not sure, but I still see the title associated to the label instead of it being associated to the checkbox. Or maybe I'm doing something wrong.

Also, in the source code I still see the "field" attribute associated to the entry, while in Joe's PR I see the "field" attributes switched from the entry to the checkbox, along with all the others. Is there a reason to keep the field attribute in the entry in these cases?

[timja]

There’s been a few commits to the PR since the screenshot was taken, help icon alignment has been fixed and related nested item layout has been adjusted.

I’m not sure if the field attribute location matters.

That would be why it looks different