Replace javax annotations with spotbugs annotations #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent with git client plugin
No equivalent replacement in spotbugs annotations and this is the only location which depends on this final remaining JSR 305 annotation.
fcojfernandez
approved these changes
Mar 27, 2020
MarkEWaite
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace javax annotations with spotbugs annotations
The javax annotations from JSR-305 were never finalized and never will be finalized. The spotbugs team has provided replacements that match with spotbugs usage.
Also updates to spotbugs 4.0.1.
Checklist
Types of changes
In the spirit of jenkinsci/jenkins#4604