[GSoC] Addition of unit test for WipeWorkspace extension behavior in GitSCM #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
requested changes
Mar 6, 2020
src/test/java/hudson/plugins/git/extensions/impl/WipeWorkspaceTest.java
Outdated
Show resolved
Hide resolved
… for equalsContract
MarkEWaite
approved these changes
Mar 6, 2020
|
The last commit after your approval is just a shift of code from before() method inorder to run equalsContract() test without JenkinsRule. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test was added in relevance to one the project goals of Git-Plugin Performance Improvements which is to improve the code coverage.
I ran the coverage report on IntelliJ and most of the report is not relevant to the test, I have just taken out the relevant part.