[GSoC] Add UserIdentityTest to improve code coverage in git-plugin

[rishabhBudhouliya]

The unit test was added in relevance to one the project goals of Git-Plugin Performance Improvements which is to improve the code coverage.

I ran the coverage report on IntelliJ and most of the report is not relevant to the test, I have just taken out the relevant part.

Further comments

While writing tests for this class, UserIdentity, I came upon an issue with this extension, namely JENKINS-46052.

While UserIdentity sets author name and email in the environment variable, wouldn't it be right to set the new author name and email in the git.config for that particular repository as well?

git config user.name "GIT_AUTHOR_NAME"
git config user.email "GIT_AUTHOR_EMAIL"

Seems like a small fix, if needed.

[rishabhBudhouliya]

Thanks for reviewing this despite being busy, really appreciate it.

I wasn't aware of the @WithoutJenkins annotation, it sure is a good way to reduce the cost associated to a JenkinsRule.

I had to shift the creation of TestGitRepo and the GitClient to the particular test which requires JenkinsRule inorder to run one test with JenkinsRule and two without it. The before() runs before each test, hence was not letting the other two run without it.

[MarkEWaite]

When I merge this commit, I will likely use "Rebase and merge" rather than "Merge" because the commit on which it is based is quite a few commits behind the current master branch.

You may want to investigate the hub command for convenience. It includes a command hub sync which will update your local branches (like master) with the latest results from the upstream repositories. It also has a very nice command hub pr checkout nnn which will checkout a branch for the pull request nnn.

Please don't rebase the commit yourself because that damages the GitHub comments. Better to let GitHub do the rebase.

[MarkEWaite]

Will merge next week when I'm home from traveling.

[rishabhBudhouliya]

After your comment I just saw that my fork was 91 commits behind the jenkinsci git-plugin repo.
I'll definitely look into hub because I have tried merging the original repo into my forked repo just now.

In the further comments section, I have discussed the need of changing the implementation of UserIdentity. Maybe we can discuss it after you come back, nevertheless thank you so much!