Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-71876] Add "NOTIFY_COMMIT_ACCESS_CONTROL" examples #1641

Merged
merged 10 commits into from
Aug 21, 2024
Merged

[JENKINS-71876] Add "NOTIFY_COMMIT_ACCESS_CONTROL" examples #1641

merged 10 commits into from
Aug 21, 2024

Conversation

sirine707
Copy link
Contributor

This update introduces a section to the documentation that covers the NOTIFY_COMMIT_ACCESS_CONTROL feature. It includes instructions on how to configure and use it.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira

@sirine707 sirine707 requested a review from a team as a code owner August 20, 2024 20:45
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 20, 2024
@MarkEWaite
Copy link
Contributor

Thanks! It needs to move into the section that describes notifyCommit rather than being its own dedicated section. The text that describes notifyCommit alternatives is already available in that section and is more precise than the description that you've added.

@MarkEWaite MarkEWaite changed the title [JENKINS-71876] Added "NOTIFY_COMMIT_ACCESS_CONTROL" section to the documentation [JENKINS-71876] Add "NOTIFY_COMMIT_ACCESS_CONTROL" examples Aug 20, 2024
sirine707 and others added 8 commits August 20, 2024 22:41
@sirine707
Merge branch 'jenkinsci:master' into update-notifyCommit-docs
a0d77b1
@sirine707
Updated README file
9c5f636
@MarkEWaite
Remove GitPod configuration
633c7d3
@MarkEWaite
Use disabled-for-polling in examples
878f1b1 
Since `disabled` is not recommneded, let's use a little more favorable
example to allow anonymous notifyCommit so long as the request only
invokes polling.

Include links that provide more information to describe system properties
and Groovy post inititalization scripts.
@MarkEWaite
Add prefix text for system property
c65a066 
Move mode descriptions before method description
@MarkEWaite
Retain indentation for code fragment
435ca6d
@MarkEWaite
Remove groovy specific formatting from example
21d3b0e 
Looks better without it
@MarkEWaite
Move return value description earlier
3399e39
MarkEWaite
MarkEWaite approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite MarkEWaite enabled auto-merge (squash) August 21, 2024 01:30
@MarkEWaite MarkEWaite disabled auto-merge August 21, 2024 01:33
@MarkEWaite MarkEWaite merged commit c380f5b into jenkinsci:master Aug 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirine707 @MarkEWaite