Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git-client based on Apache Mina #1579

Closed
wants to merge 9 commits into from

Conversation

olamy
Copy link
Member

@olamy olamy commented Apr 23, 2024

  • use git-client SNAPSHOT with Mina
  • test with incremental of git-client-plugin
  • temporart testing
  • do not set default credentials for testing remote access

JENKINS-xxxxx - summarize pull request in one line

Describe the big picture of your changes here to explain to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, include a link to the issue.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code. If a checkbox or line does not apply to this pull request, delete it. We prefer all checkboxes to be checked before a pull request is merged

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. Delete the items in the list that do not apply

  • Dependency or infrastructure update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Further comments

If this is a relatively large or complex change, start the discussion by explaining why you chose the solution you did and what alternatives you considered.

@olamy olamy added the bug Incorrect or flawed behavior label Apr 23, 2024
@github-actions github-actions bot added the dependencies Dependency related change label Apr 23, 2024
@olamy olamy force-pushed the fix-credentials-remote-check branch from 47337b3 to c784cf2 Compare May 10, 2024 08:39
@olamy olamy force-pushed the fix-credentials-remote-check branch 2 times, most recently from 06f2368 to 6c0a8d2 Compare June 3, 2024 22:01
@olamy olamy changed the title fix credentials remote check Use git-client based on Apache Mina Jun 7, 2024
@olamy
Copy link
Member Author

olamy commented Jun 7, 2024

depends on jenkinsci/git-client-plugin#1127

@olamy olamy removed the bug Incorrect or flawed behavior label Jun 7, 2024
@olamy olamy force-pushed the fix-credentials-remote-check branch from 2d033f9 to 0d16132 Compare June 10, 2024 00:49
@MarkEWaite
Copy link
Contributor

Closing because this is now implemented with the most recent change to the plugin bill of materials, as merged in:

@MarkEWaite MarkEWaite closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants