disable tag.gpgsign as it could be active for some systems #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsandell
approved these changes
Feb 16, 2024
olamy
commented
Feb 19, 2024
pom.xml
Outdated
| @@ -102,6 +102,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>git-client</artifactId> | |||
| <version>4.6.1-rc3521.3dcd9ff316b_4</version> | |||
There was a problem hiding this comment.
temporary to test with jenkinsci/git-client-plugin#1107
There was a problem hiding this comment.
The git client plugin dependency on the master branch is now updated to git client plugin 4.7.0 that includes the test fixes for autosign. Thanks again for making these improvements!
There was a problem hiding this comment.
@MarkEWaite yeah. thanks for the ping ;)
I update that here. But I still have one issue with with auto sign I need to figure out.
Expected: is <SUCCESS>
but: was <FAILURE>
[ERROR] Errors:
[ERROR] CredentialsUserRemoteConfigTest.checkoutWithValidCredentials:273->Object.wait:328->Object.wait:-2 » TestTimedOut test timed out after 180 seconds
There was a problem hiding this comment.
well this looks to be a flaky test
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
olamy
force-pushed
the
tag-gpg-auto-sign
branch
from
4bae916 to
0bac973
Compare
olamy
changed the title
MarkEWaite
approved these changes
Mar 17, 2024
pom.xml
Outdated
| @@ -102,6 +102,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>git-client</artifactId> | |||
| <version>4.6.1-rc3521.3dcd9ff316b_4</version> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test cases related to
taggit command can fail in case of the following~/.gitconfigconfigurationChecklist
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply. Delete the items in the list that do not apply