Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plugin bom more widely #1496

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

MarkEWaite
Copy link
Contributor

Use plugin bom more widely

parameterized-trigger now managed by bom

conditional-buildstep not needed as a dependency

maven plugin now mannaged by bom

Needs to be verified in the plugin bill of materials before it is merged. Previous attempts to remove the conditional-buildstep dependency passed tests in the git plugin but failed in the bill of materials when the maven plugin was being loaded.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Tests

parameterized-trigger now managed by bom

conditional-buildstep not needed

maven plugin now mannaged by bom
@github-actions github-actions bot added dependencies Dependency related change and removed test labels Aug 10, 2023
@MarkEWaite MarkEWaite enabled auto-merge (squash) August 10, 2023 04:44
@MarkEWaite MarkEWaite merged commit 6172534 into jenkinsci:master Aug 10, 2023
@MarkEWaite MarkEWaite deleted the simplify-dependencies branch August 10, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant