Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip hook assertion on git 1.8 #1325

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

MarkEWaite
Copy link
Contributor

Skip hook assertions on CLI git 1.8

Hook message is displayed when I run git interactively but does not appear in the console log when the test is run. Not worth the time to research why command line 1.8 is different from all the other git versions that are being tested.

Unclear why that old git version behaves differently than all the other versions that are being tested. Not worth the time to investigate the root cause. Accept that command line git 1.8 is a very old version that has several exceptions already included in the plugin.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Test

Hook message is displayed when I run git interactively but does
not appear in the console log when the test is run.  Not worth the
time to research why command line 1.8 is different from all the
other git versions that are being tested.

Unclear why that old git version behaves differently than all the other
versions that are being tested.  Not worth the time to investigate the
root cause.  Accept that command line git 1.8 is a very old version that
has several exceptions already included in the plugin.
@github-actions github-actions bot added the test label Sep 3, 2022
@MarkEWaite MarkEWaite merged commit 249a8d3 into jenkinsci:master Sep 4, 2022
@MarkEWaite MarkEWaite deleted the fix-rhel-7-hooks-failures branch September 4, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant