Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on older CLI git versions #1324

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Sep 3, 2022

Fix tests on older versions of command line git

The git branch -m master fails on a repository created with command line git versions 2.25, 2.20, 2.17, and 1.8. It works with git versions 2.30 and later.

Setting was added in July 2022 as part of #1295 for systems that have their default branch name configured as something other than master.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Test

The `git branch -m master` fails on a repository created with command
line git versions 2.25, 2.20, 2.17, and 1.8.  It works with git versions
2.30 and later.

Setting was added in July 2022 for systems that have their default
branch name configured as something other than `master`.
@github-actions github-actions bot added the test label Sep 3, 2022
@MarkEWaite MarkEWaite merged commit ede7d48 into jenkinsci:master Sep 3, 2022
@MarkEWaite MarkEWaite deleted the fix-tests-on-older-git-versions branch September 3, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant