Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code modernization #1294

Merged
merged 10 commits into from
Aug 9, 2022
Merged

Code modernization #1294

merged 10 commits into from
Aug 9, 2022

Conversation

offa
Copy link
Contributor

@offa offa commented Jul 20, 2022

Code modernization, mostly Java <= 8 features, Junit asserts and cleanup.

PS. Are there any plans to un-fork this project?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code. If a checkbox or line does not apply to this pull request, delete it. We prefer all checkboxes to be checked before a pull request is merged

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. Delete the items in the list that do not apply

Further comments

/

@github-actions github-actions bot added the test label Jul 20, 2022
@MarkEWaite MarkEWaite added chore Reduces maintenance effort by changes not directly visible to users and removed test labels Aug 8, 2022
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I believe this is ready to merge once it passes CI tests

@MarkEWaite MarkEWaite merged commit 6525c27 into jenkinsci:master Aug 9, 2022
@offa offa deleted the modernize branch August 15, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants