Work around JENKINS-67309 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered when doing manual compatibility testing last December, but also appears when testing early iterations of JENKINS-45047 (which essentially automates that manual procedure). I suspect the only reason this does not show up in current versions of PCT is that PCT has a flawed methodology for dependency updating. Anyway, the problem appears to be in the code under test rather than in the test, so pending a fix for the underlying bug let us relax this test to avoid spurious errors from compatibility testing tools. This PR does so by relaxing the check to the simple class name rather than the exact class. Of course it is not expected that we would be matching a class from a different plugin, but that is the point of JENKINS-67309.