Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about unexpected default branch name. #1246

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

jmMeessen
Copy link
Contributor

Tests can fail if the default branch name is not the traditional "master". This PR warns of this problem in the CONTRIBUTING.md and explains how to temporarily disable the setting.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Documentation

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 2, 2022
@MarkEWaite MarkEWaite merged commit 7901c55 into jenkinsci:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants